[PATCH] D11382: x86 atomic: optimize a.store(reg op a.load(acquire), release)

[Robin Morisset]

morisset added a comment.

LGTM for the integer part.

I am not really convinced that the floating point change belongs in the same patch: it is conceptually different, and does not seem to share any code with the rest of the patch. It is also not obvious to me why it is only tested on X86_64, a comment would be appreciated.


================
Comment at: test/CodeGen/X86/atomic_mi.ll:847
@@ +846,3 @@
+; X32-LABEL: fadd_32r:
+; Don't check x86-32.
+  %floc = bitcast float* %loc to i32*
----------------
Why ?

================
Comment at: test/CodeGen/X86/atomic_mi.ll:864
@@ +863,3 @@
+; X32-LABEL: fadd_64r:
+; Don't check x86-32.
+  %floc = bitcast double* %loc to i64*
----------------
Why ?


http://reviews.llvm.org/D11382