Re: [PATCH] D11369: WebAssembly: basic bitcode → assembly CodeGen test

[JF Bastien]

jfb added a comment.

I did a bit of grep-fu and found the following:

  git grep "^#define DEBUG_TYPE" | cut -f3 -d' '| sort | uniq -c | sort -h | grep -v " 1 "
        2 "aarch64-disassembler"
        2 "arm-isel"
        2 "bugpoint"
        2 "codegen"
        2 "coverage-mapping"
        2 "delay-slot-filler"
        2 "flattencfg"
        2 "hexagon-shuffle"
        2 "indvars"
        2 "instsimplify"
        2 "jit"
        2 "mem2reg"
        2 "mips-lower"
        2 "mips-reg-info"
        2 "packets"
        2 "scheduler"
        2 "simplifycfg"
        2 "ssaupdater"
        2 "stackmaps"
        2 "subtarget-emitter"
        2 "x86-isel"
        3 "inline"
        3 "ir"
        3 "isel"
        3 "lli"
        3 "loop-unroll"
        3 "post-RA-sched"
        3 "region"
        4 "block-freq"
        4 "dwarfdebug"
        4 "misched"
        5 "legalize-types"
        5 "mips-isel"
        6 "pre-RA-sched"
        9 "mccodeemitter"
       11 "dyld"
       15 "instcombine"
       17 "regalloc"
       25 "asm-printer"

Is this worth fixing?


================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:36
@@ +35,3 @@
+
+#define DEBUG_TYPE "asm-printer"
+
----------------
sunfish wrote:
> Should this be "wasm-asm-printer"? And should the one in InstPrinter/WebAssemblyInstPrinter.cpp be that too?
That doesn't seem to be what other targets do:
```
git grep DEBUG_TYPE ./lib/Target/*/*AsmPrinter.cpp
lib/Target/AArch64/AArch64AsmPrinter.cpp:#define DEBUG_TYPE "asm-printer"
lib/Target/ARM/ARMAsmPrinter.cpp:#define DEBUG_TYPE "asm-printer"
lib/Target/BPF/BPFAsmPrinter.cpp:#define DEBUG_TYPE "asm-printer"
lib/Target/Hexagon/HexagonAsmPrinter.cpp:#define DEBUG_TYPE "asm-printer"
lib/Target/MSP430/MSP430AsmPrinter.cpp:#define DEBUG_TYPE "asm-printer"
lib/Target/Mips/MipsAsmPrinter.cpp:#define DEBUG_TYPE "mips-asm-printer"
lib/Target/PowerPC/PPCAsmPrinter.cpp:#define DEBUG_TYPE "asmprinter"
lib/Target/Sparc/SparcAsmPrinter.cpp:#define DEBUG_TYPE "asm-printer"
lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:#define DEBUG_TYPE "asm-printer"
lib/Target/XCore/XCoreAsmPrinter.cpp:#define DEBUG_TYPE "asm-printer"
```

Should they? I can change all of them if so, probably in a different change.


Repository:
  rL LLVM

http://reviews.llvm.org/D11369