[PATCH] D7203: [asan] Set abort_on_error=1 by default on OS X

Kuba Brecka kuba.brecka at gmail.com
Wed Jul 22 12:46:31 PDT 2015


kubabrecka added a comment.

> Where are you filtering which tests get executed, though? It looks like both will always be executed, and one will fail.


It's based on the directory the test is in.  Tests in `TestCases/Darwin/` are only run on Darwin.

> ... Possibly even SANITIZER_MAC || SANITIZER_IOSSIM || SANITIZER_IOS...


`SANITIZER_MAC` is `1` on all these three platforms.

> Why do you do this here, if lit.cfg already sets ASAN_OPTIONS?


Unit tests don't use settings from `test/asan/lit.cfg`, AFAIK.


http://reviews.llvm.org/D7203







More information about the llvm-commits mailing list