[llvm] r242920 - Remove C++98 workaround in llvm::sys::DontRemoveFileOnSignal()

Yaron Keren yaron.keren at gmail.com
Wed Jul 22 11:23:51 PDT 2015


Author: yrnkrn
Date: Wed Jul 22 13:23:51 2015
New Revision: 242920

URL: http://llvm.org/viewvc/llvm-project?rev=242920&view=rev
Log:
Remove C++98 workaround in llvm::sys::DontRemoveFileOnSignal()


Modified:
    llvm/trunk/lib/Support/Unix/Signals.inc

Modified: llvm/trunk/lib/Support/Unix/Signals.inc
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Unix/Signals.inc?rev=242920&r1=242919&r2=242920&view=diff
==============================================================================
--- llvm/trunk/lib/Support/Unix/Signals.inc (original)
+++ llvm/trunk/lib/Support/Unix/Signals.inc Wed Jul 22 13:23:51 2015
@@ -268,13 +268,6 @@ void llvm::sys::DontRemoveFileOnSignal(S
   std::vector<std::string>::iterator I = FilesToRemove->end();
   if (RI != FilesToRemove->rend())
     I = FilesToRemove->erase(RI.base()-1);
-
-  // We need to call c_str() on every element which would have been moved by
-  // the erase. These elements, in a C++98 implementation where c_str()
-  // requires a reallocation on the first call may have had the call to c_str()
-  // made on insertion become invalid by being copied down an element.
-  for (std::vector<std::string>::iterator E = FilesToRemove->end(); I != E; ++I)
-    I->c_str();
 }
 
 /// AddSignalHandler - Add a function to be called when a signal is delivered





More information about the llvm-commits mailing list