[PATCH] D11326: [Release] Allow release testers to disable certain components

[Renato Golin]

rengolin added inline comments.

================
Comment at: utils/release/test-release.sh:22
@@ -22,1 +21,3 @@
+# Basic projects, always built
+projects="llvm cfe clang-tools-extra"
 
----------------
hans wrote:
> Could we move this down to where the optional projects are added? It would be easier to follow if they were close to each other in the source.
good point

================
Comment at: utils/release/test-release.sh:246
@@ +245,3 @@
+        if [ -d $proj.src ]; then
+          echo "# Reusing $proj $Release-$RC sources"
+          continue
----------------
hans wrote:
> Doesn't -no-checkout cover this use case?
To a point, yes. But I'd argue that this is a better solution that replaces -no-checkout, which avoids the whole validate+checkout+symlink.

My reasoning is that -no-checkout exists so that you can either use an external source tree, or continue from a failed previous attempt. 

For the former, with this solution you still control the links to the other projects (via -no-rt, etc), and also checkout the missing projects you haven't used.

For the latter, if the failure is in SVN or symlinks, -no-checkout won't work, as it's all or nothing.


Repository:
  rL LLVM

http://reviews.llvm.org/D11326