[PATCH] D11262: [SDAG] Add new ISD nodes: ISD::FMINNAN and ISD::FMAXNAN

[Matt Arsenault]

arsenm added a comment.

Do these have a corresponding IR intrinsic like fminnum/fmaxnum because I don't see the SelectionDAGBuilder part?


================
Comment at: include/llvm/CodeGen/ISDOpcodes.h:509-513
@@ -508,3 +508,7 @@
     FCEIL, FTRUNC, FRINT, FNEARBYINT, FROUND, FFLOOR,
-    FMINNUM, FMAXNUM,
+    /// FMINNUM/FMAXNUM, FMINNAN/FMAXNAN - perform floating-point minimum or 
+    /// maximum on two values. The NUM/NAN variants differ in their behavior
+    /// when given a single NaN input. The NUM variants will return the non-NaN
+    /// operand, whereas the NAN variants will return the NaN operand.
+    FMINNUM, FMAXNUM, FMINNAN, FMAXNAN,
 
----------------
I think this comment should be split into a more detailed description of just FMINNUM/FMAXNUM, and then a separate comment for how FMINNAN/FMAXNAN differs


Repository:
  rL LLVM

http://reviews.llvm.org/D11262