[PATCH] D7203: [asan] Set abort_on_error=1 by default on OS X

[Anna Zaks]

zaks.anna added a comment.

> I'm sympathetic to your concerns regarding

>  running tests in a different configuration that is shipped by default to the end users, and this can apply

>  to different abort_on_error values on different OSes, but not for the existing state.


While I am also sympathetic, I prefer having a more complicated tests setup to a bad end user experience, which is what we get on darwin with the current behavior (I believe we've reached a consensus on this above).

I recall people getting confused by non-crashing behavior on other platforms as well. Here are a few links I found with instructions to manually reset the default by doing a quick search:

https://code.google.com/p/address-sanitizer/issues/detail?id=345
https://groups.google.com/forum/#!searchin/address-sanitizer/abort_on_error/address-sanitizer/ROkIGdTicgg/gDc3wLlbrr8J
https://code.google.com/p/address-sanitizer/wiki/AddressSanitizerAndDebugger
https://llvm.org/bugs/show_bug.cgi?id=16276
https://fuzzing-project.org/tutorial2.html
https://trac.webkit.org/wiki/ASanWebKit


http://reviews.llvm.org/D7203