[llvm] r242893 - [GMR] Switch from std::set to SmallPtrSet. NFC.

Chandler Carruth chandlerc at gmail.com
Wed Jul 22 04:47:54 PDT 2015


Author: chandlerc
Date: Wed Jul 22 06:47:54 2015
New Revision: 242893

URL: http://llvm.org/viewvc/llvm-project?rev=242893&view=rev
Log:
[GMR] Switch from std::set to SmallPtrSet. NFC.

This almost certainly doesn't matter in some deep sense, but std::set is
essentially always going to be slower here. Now the alias query should
be essentially constant time instead of having to chase the set tree
each time.

Modified:
    llvm/trunk/lib/Analysis/IPA/GlobalsModRef.cpp

Modified: llvm/trunk/lib/Analysis/IPA/GlobalsModRef.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/IPA/GlobalsModRef.cpp?rev=242893&r1=242892&r2=242893&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/IPA/GlobalsModRef.cpp (original)
+++ llvm/trunk/lib/Analysis/IPA/GlobalsModRef.cpp Wed Jul 22 06:47:54 2015
@@ -16,6 +16,7 @@
 
 #include "llvm/Analysis/Passes.h"
 #include "llvm/ADT/SCCIterator.h"
+#include "llvm/ADT/SmallPtrSet.h"
 #include "llvm/ADT/Statistic.h"
 #include "llvm/Analysis/AliasAnalysis.h"
 #include "llvm/Analysis/CallGraph.h"
@@ -30,7 +31,6 @@
 #include "llvm/Pass.h"
 #include "llvm/Support/CommandLine.h"
 #include <list>
-#include <set>
 using namespace llvm;
 
 #define DEBUG_TYPE "globalsmodref-aa"
@@ -89,11 +89,11 @@ struct FunctionRecord {
 /// GlobalsModRef - The actual analysis pass.
 class GlobalsModRef : public ModulePass, public AliasAnalysis {
   /// The globals that do not have their addresses taken.
-  std::set<const GlobalValue *> NonAddressTakenGlobals;
+  SmallPtrSet<const GlobalValue *, 8> NonAddressTakenGlobals;
 
   /// IndirectGlobals - The memory pointed to by this global is known to be
   /// 'owned' by the global.
-  std::set<const GlobalValue *> IndirectGlobals;
+  SmallPtrSet<const GlobalValue *, 8> IndirectGlobals;
 
   /// AllocsForIndirectGlobals - If an instruction allocates memory for an
   /// indirect global, this map indicates which one.





More information about the llvm-commits mailing list