[PATCH] D7203: [asan] Set abort_on_error=1 by default on OS X

[Filipe Cabecinhas]

Hi all,
Sorry for not replying earlier.

Kostya:
It encourages changes if needed, yes.
Like when a platform needs to change something related to other platforms
where ASan runs, and would require lots of changes to tests.

We also clear away ASAN_OPTIONS (and the others) when we run tests, which
allows us to make minimum assumptions when running them. This specific
change seems to be strictly on the "positive" side. Without it we could
simply fail some tests because the user happened to have a specific option
turned on by default and ran the ASan tests.

By having ASAN_OPTIONS be reset by lit, and then having each test that
cares about it adding or replacing it, we can test the options themselves,
their absence, and have "proper" defaults for the tests.
It also allows us to "easily" have platforms specify their own defaults for
flags, like what Kuba wants to do.

About this specific change:
It's surprising (to me) to have ASan, by default, exit() the process, as if
"no error" had happened (by which I mean: The process exited in a "normal"
way, even though it exited with a failure exit code). This doesn't affect
me much, as an exit() on my platform is also "weird". But on Mac OS X it
feels weird to not have it crash.


Regards,

  Filipe

On Tue, Jul 21, 2015 at 3:30 PM, Kostya Serebryany <kcc at google.com> wrote:

> kcc added a comment.
>
> But the existing state encourage more changes to ASAN_OPTIONS in lit.cfg.
> We at the very least should warn in the comments about adding more options
> there,
> but better remove this too.
>
>
> http://reviews.llvm.org/D7203
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150721/e153fdf8/attachment.html>