[PATCH] D7203: [asan] Set abort_on_error=1 by default on OS X

Alexey Samsonov vonosmas at gmail.com
Tue Jul 21 15:28:38 PDT 2015


samsonov added a subscriber: filcab.
samsonov added a comment.

In http://reviews.llvm.org/D7203#209307, @kcc wrote:

> In http://reviews.llvm.org/D7203#209296, @zaks.anna wrote:
>
> > It's been added by an unrelated commit, see http://reviews.llvm.org/D10294.
>
>
> Sure. I think this was a mistake and a very bad way forward.


I think it was me who approved that change by Filipe. I'm sympathetic to your concerns regarding
running tests in a different configuration that is shipped by default to the end users, and this can apply
to different `abort_on_error` values on different OSes, but not for the existing state.


http://reviews.llvm.org/D7203







More information about the llvm-commits mailing list