[PATCH] D7203: [asan] Set abort_on_error=1 by default on OS X

Alexey Samsonov vonosmas at gmail.com
Tue Jul 21 12:18:34 PDT 2015


samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

FWIW I'm fine with letting you decide the default flag value for Mac.


================
Comment at: test/asan/TestCases/Darwin/abort_on_error-darwin.cc:15
@@ +14,3 @@
+  // CHECK: {{.*ERROR: AddressSanitizer: heap-use-after-free on address}}
+  // CHECK:   {{0x.* at pc 0x.* bp 0x.* sp 0x.*}}
+}
----------------
Remove this CHECK line, it doesn't seem to be important for test.

================
Comment at: test/asan/TestCases/Linux/abort_on_error-linux.cc:15
@@ +14,3 @@
+  // CHECK: {{.*ERROR: AddressSanitizer: heap-use-after-free on address}}
+  // CHECK:   {{0x.* at pc 0x.* bp 0x.* sp 0x.*}}
+}
----------------
ditto


http://reviews.llvm.org/D7203







More information about the llvm-commits mailing list