[PATCH] MIR Serialization: Initial serialization of constant pools and constant pool operands.

Alex L arphaman at gmail.com
Mon Jul 20 13:52:49 PDT 2015


Thanks, I committed this patch with the added tests for the non-standard
alignment in r242707.

2015-07-17 11:02 GMT-07:00 Duncan P. N. Exon Smith <dexonsmith at apple.com>:

>
> > On 2015-Jul-17, at 10:18, Alex L <arphaman at gmail.com> wrote:
> >
> > Hello,
> >
> > This patch depends on the patch D10280 (AsmParser: Add a function to
> parse a standalone type and value).
> >
> > This patch implements initial serialization of the machine constant pool
> and the constant pool
> > index machine operand. The constant pool is serialized by using a YAML
> sequence of YAML
> > mappings that represent the constant values, e.g:
> >
> >   constants:
> >     - id:          0
> >       value:       'double 3.250000e+00'
> >       alignment:   8
> >     - id:          1
> >       value:       'float 6.250000e+00'
> >       alignment:   4
> >
> > Target-specific constant pool values aren't serialized by this patch.
> >
> > The constant pool index machine operands use the following syntax:
> >
> >   %const.<id>
> >
> > Thanks,
> > Alex
> > <0001-MIR-Serialization-Initial-serialization-of-constant-.patch>
>
> Please add a test that checks that non-standard alignments are
> respected -- that inferred alignments don't override specified ones.
>
> With that, LGTM.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150720/b6748a5b/attachment.html>


More information about the llvm-commits mailing list