[PATCH] D11146: [ValueTracking] Add support for floating-point minnum and maxnum

Matt Arsenault Matthew.Arsenault at amd.com
Mon Jul 20 13:15:35 PDT 2015


arsenm added inline comments.

================
Comment at: test/Transforms/InstCombine/minmax-fp.ll:4-5
@@ +3,4 @@
+; CHECK-LABEL: @t1
+; CHECK-NEXT: fcmp
+; CHECK-NEXT: select
+; CHECK-NEXT: fpext
----------------
I think these really need to check the operands of these instructions. At the very minimum, at least the fcmp compare type.

Besides that LGTM


Repository:
  rL LLVM

http://reviews.llvm.org/D11146







More information about the llvm-commits mailing list