[PATCH] D11354: [X86][AVX512F] add arithmetic intrinsics
Elena Demikhovsky
elena.demikhovsky at intel.com
Mon Jul 20 12:16:54 PDT 2015
delena added a comment.
I think that we are inconsistent with "setzero" and "undef" for PathThru values in this file. GCC uses "undef" and it is right.
================
Comment at: lib/Headers/avx512fintrin.h:52
@@ -51,2 +51,3 @@
/* Create vectors with repeated elements */
+static __inline __m512 __DEFAULT_FN_ATTRS
----------------
This comment should be moved down, it is related to setzero.
================
Comment at: lib/Headers/avx512fintrin.h:889
@@ -871,3 +888,3 @@
(__v16si)
_mm512_setzero_si512 (),
(__mmask16) -1);
----------------
In all these cases we also should use "undefined". Right?
Repository:
rL LLVM
http://reviews.llvm.org/D11354
More information about the llvm-commits
mailing list