[PATCH] D11136: [mips] Added support for the ERETNC instruction.

[Vasileios Kalintiris]

vkalintiris requested changes to this revision.
vkalintiris added a comment.
This revision now requires changes to proceed.

We can re-use the classes ER_FM and ER_FT for the definition of the ERETNC instruction.

Also, I believe that we should use (or create) invalid-mips32r5.s in order to test errors for pre-R5 ISAs. Please. wait for Daniel's response on that.


================
Comment at: lib/Target/Mips/MipsInstrFormats.td:656-664
@@ -655,2 +655,11 @@
 
+class ERNC_FM<bits<6> funct> : StdArch
+{
+  bits<32> Inst;
+  let Inst{31-26} = 0x10;
+  let Inst{25}    = 1;
+  let Inst{24-7}  = 0;
+  let Inst{6} = 1;
+  let Inst{5-0}   = funct;
+}
 
----------------
We can re-use the ER_FM format above by adding a boolean parameter that sets the 6th bit.

================
Comment at: lib/Target/Mips/MipsInstrInfo.td:880-884
@@ -876,2 +879,7 @@
 
+// Eretnc
+class ERNC_FT<string opstr> :
+  InstSE<(outs), (ins),
+         opstr, [], NoItinerary, FrmOther, opstr>;
+
 // Interrupts
----------------
We can just use ER_FT for the ERETNC definition since the classes are identical.

================
Comment at: test/MC/Mips/mips32/valid-xfail.s:38
@@ -37,2 +37,3 @@
         c.un.s          $fcc1,$f30,$f4
+        eretnc
         rorv            $13,$a3,$s5
----------------
@dsanders: I believe that we should place this test in invalid-mips32r5.s for pre-R5 ISAs, right? 


http://reviews.llvm.org/D11136