chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM I'd just leave the code as is. If you can come up with tests that would tickle the int64_t and int8_t case, it'd be nice to add those. http://reviews.llvm.org/D11289