[PATCH] D11289: [X86] Widen the 'AND' mask if doing so shrinks the encoding size

[David Majnemer]

majnemer added a comment.

In http://reviews.llvm.org/D11289#207674, @chandlerc wrote:

> Ugh. The lambda didn't help as much as i had hoped because you need to only compute the known bits once. Unfortunate.


Is it still worth keeping the lambda?


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:2145-2146
@@ +2144,4 @@
+    return nullptr;
+  uint64_t Val = Cst->getSExtValue();
+  if (Val <= 0)
+    return nullptr;
----------------
chandlerc wrote:
> uint64_t(...) <= 0? Why not just == 0, or did you mean something else?
It's a victim of refactoring.  `Val` should be `int64_t`.


http://reviews.llvm.org/D11289