escha added inline comments. ================ Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:2237 @@ +2236,3 @@ + // compile time. + if ((int8_t)Val < 0) { + if (NVT.SimpleTy == MVT::i64) ---------------- Is this right? (int8_t)-384 would still pass this check, right? http://reviews.llvm.org/D11289