[PATCH] D11288: [llgo] cmd/gllgo: handle/ignore more flags

Andrew Wilkins axwalk at gmail.com
Fri Jul 17 01:13:28 PDT 2015


axw updated this revision to Diff 29981.
axw added a comment.

- Ignore all -W prefixes (apart from -Wl,)
- add TODO to handle -fstack-protector*


http://reviews.llvm.org/D11288

Files:
  cmd/gllgo/gllgo.go

Index: cmd/gllgo/gllgo.go
===================================================================
--- cmd/gllgo/gllgo.go
+++ cmd/gllgo/gllgo.go
@@ -324,6 +324,14 @@
 		case strings.HasPrefix(args[0], "-fgo-relative-import-path="):
 			// TODO(pcc): Handle this.
 
+		case strings.HasPrefix(args[0], "-fstack-protector"):
+			// TODO(axw) set ssp function attributes. This can be useful
+			// even for Go, if it interfaces with code written in a non-
+			// memory safe language (e.g. via cgo).
+
+		case strings.HasPrefix(args[0], "-W"):
+			// Go doesn't do warnings. Ignore.
+
 		case args[0] == "-fload-plugin":
 			if len(args) == 1 {
 				return opts, errors.New("missing argument after '-fload-plugin'")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11288.29981.patch
Type: text/x-patch
Size: 707 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150717/47bfa84d/attachment.bin>


More information about the llvm-commits mailing list