[PATCH] D10522: Implement target independent TLS compatible with glibc's emutls.c.
David
davidxl at google.com
Thu Jul 16 17:38:41 PDT 2015
davidxl added inline comments.
================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:440
@@ +439,3 @@
+ OutStreamer->EmitSymbolValue(
+ createEmuTLSInitSym(GVSym, OutContext), WordSize);
+ } else
----------------
srhines wrote:
> chh wrote:
> > davidxl wrote:
> > > createEmuTLSInitSym is called later again which seems wrong.
> > It's on purpose to get-or-create the symbol from one place, and createEmuTLSInitSym can be called multiple times.
> >
> In that case, let's not call the function "create...", since that implies something different. It might be better to call it getEmuTLSInitSym().
make it clear to change the interface name to be something like 'getOrCreat ...'
Repository:
rL LLVM
http://reviews.llvm.org/D10522
More information about the llvm-commits
mailing list