[PATCH] D11277: [lib/Fuzzer] Add sanitizer runtime errors unit save option

Kostya Serebryany kcc at google.com
Thu Jul 16 14:57:50 PDT 2015


kcc added a comment.

First question: why is a log file not enough? 
It will contain the full sanitizer report (not just summary) and the reproducer. 
Frankly, to me this looks like a duplicated functionality.


================
Comment at: lib/Fuzzer/FuzzerFlags.def:62
@@ +61,3 @@
+FUZZER_FLAG_INT(save_runtime_sanitizer_errors, 0,
+                "Save runtime sanitizer errors"
+                " For example from fsanitize=undefined")
----------------
write more detailed description (e.g. "save sanitizer error report to a file with 'error-' prefix" or some such)

================
Comment at: lib/Fuzzer/FuzzerLoop.cpp:16
@@ -15,1 +15,3 @@
 
+void __sanitizer_report_error_summary(const char *ErrorSummary) {
+  fuzzer::Fuzzer::StaticErrorReportCallback(ErrorSummary);
----------------
__sanitizer_report_error_summary may be used by other parts of code linked with libSanitizer. 
Also, summary is just a single line, not sure how it may be useful. 


http://reviews.llvm.org/D11277







More information about the llvm-commits mailing list