[PATCH] D11243: [ARM] Force LR spill in thumb2 noreturn functions

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Thu Jul 16 12:47:27 PDT 2015


bruno abandoned this revision.
bruno added a comment.

In http://reviews.llvm.org/D11243#205972, @qcolombet wrote:

> Hi Bruno,
>
> I guess that it is general goodness to have the right stack trace when you debug something, but I thought noreturn + nounwind allow the compiler to trash the information for optimization purposes?


Yep, thanks for pointing that out, I completely missed the unwind meaning here!

> I am not saying that your patch is wrong, I am pointing out that it seems we regress some pattern to improve the debug experience, and I am not sure this is something we should do.


Seems reasonable! One can always use "-funwind-tables" to override the behavior and LR will be there.
Thanks,


Repository:
  rL LLVM

http://reviews.llvm.org/D11243







More information about the llvm-commits mailing list