[llvm] r242393 - [Mips] Make helper function static, NFC.

Benjamin Kramer benny.kra at gmail.com
Thu Jul 16 10:08:40 PDT 2015


> On 16.07.2015, at 18:57, David Blaikie <dblaikie at gmail.com> wrote:
> 
> 
> 
> On Thu, Jul 16, 2015 at 4:12 AM, Benjamin Kramer <benny.kra at googlemail.com> wrote:
> Author: d0k
> Date: Thu Jul 16 06:12:05 2015
> New Revision: 242393
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=242393&view=rev
> Log:
> [Mips] Make helper function static, NFC.
> 
> Just curious: are you or have you tried turning on -Wmissing-prototypes?

I have it switched on for my local build, but there are some false positives, especially weirdly layered tblgenerated stuff.

- Ben

>  
> 
> Modified:
>     llvm/trunk/lib/Target/Mips/MipsSEFrameLowering.cpp
> 
> Modified: llvm/trunk/lib/Target/Mips/MipsSEFrameLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsSEFrameLowering.cpp?rev=242393&r1=242392&r2=242393&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/Mips/MipsSEFrameLowering.cpp (original)
> +++ llvm/trunk/lib/Target/Mips/MipsSEFrameLowering.cpp Thu Jul 16 06:12:05 2015
> @@ -622,7 +622,8 @@ MipsSEFrameLowering::hasReservedCallFram
>  }
> 
>  /// Mark \p Reg and all registers aliasing it in the bitset.
> -void setAliasRegs(MachineFunction &MF, BitVector &SavedRegs, unsigned Reg) {
> +static void setAliasRegs(MachineFunction &MF, BitVector &SavedRegs,
> +                         unsigned Reg) {
>    const TargetRegisterInfo *TRI = MF.getSubtarget().getRegisterInfo();
>    for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI)
>      SavedRegs.set(*AI);
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 





More information about the llvm-commits mailing list