[PATCH] D11149: Fix memcheck interval ends for pointers with negative strides

[silviu.baranga at arm.com]

sbaranga added a comment.

Hi Renato,

In http://reviews.llvm.org/D11149#206320, @rengolin wrote:

> Nice catch! LGTM too.
>
> Have we regressed anything? I seriously doubt it, but it's always good to check.
>
> cheers,
> --renato


Thanks! I've tested with the llvm test suite, spec2000 and spec2006 for aarch64. I didn't see any regressions. I've seen some potential improvements in some spec benchmarks, but I think it is only noise.

-Silviu


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:144-147
@@ +143,6 @@
+    // expressions.
+    const SCEV *Min = SE->getUMinExpr(ScStart, ScEnd);
+    const SCEV *Max = SE->getUMaxExpr(ScStart, ScEnd);
+    ScStart = Min;
+    ScEnd = Max;
+  }
----------------
Looks like I've missed this comment, will fix before committing.




http://reviews.llvm.org/D11149