[PATCH] D11218: AVX512 : Integer Truncate with/without saturation support

[Elena Demikhovsky]

delena added inline comments.

================
Comment at: include/llvm/IR/IntrinsicsX86.td:5294
@@ +5293,3 @@
+let TargetPrefix = "x86" in {
+  def int_x86_avx512_mask_pmov_qb_128 :
+          GCCBuiltin<"__builtin_ia32_pmovqb128_mask">,
----------------
hfinkel wrote:
> delena wrote:
> > ab wrote:
> > > So, this file is starting to get pretty unwieldy.  Why not use multiclasses?
> > Ahmed, we don't want to change format of this file now. We need to add hundreds of intrinsics and we generate these lines. Multiclasses will require manual code. It will significantly slow down the process.
> > 
> Could you contribute the code that you use to generate the intrinsic definitions?
> 
> I'm not entirely sure that a multiclass would help here (as I recall, TableGen does not have a 'map' data structure, and that's probably what you want here). However, to the extent possible, we should have human-maintainable code. TableGen alone might not currently be the best tool for this right now, but if so, we should have a detailed understanding of why.
> 
We can't contribute the generator. It is an informal semiautomatic process based on parsing intrinscs headers. But it significantly simplifies our life when we need to add such amount of intrinsics.


Repository:
  rL LLVM

http://reviews.llvm.org/D11218