[llvm] r235483 - [patchpoint] Add support for symbolic patchpoint targets to SelectionDAG and the

[Hal Finkel]

----- Original Message -----
> From: "Philip Reames" <listmail at philipreames.com>
> To: "Hal Finkel" <hfinkel at anl.gov>, "Lang Hames" <lhames at gmail.com>
> Cc: llvm-commits at cs.uiuc.edu
> Sent: Wednesday, July 15, 2015 11:44:48 AM
> Subject: Re: [llvm] r235483 - [patchpoint] Add support for symbolic patchpoint targets to SelectionDAG and the
> 
> On 07/11/2015 09:18 PM, Hal Finkel wrote:
> >> +; Trivial symbolic patchpoint codegen.
> >> >+;
> >> >+
> >> >+declare i64 @foo(i64 %p1, i64 %p2)
> >> >+define i64 @trivial_symbolic_patchpoint_codegen(i64 %p1, i64
> >> >%p2) {
> >> >+entry:
> >> >+; CHECK-LABEL: trivial_symbolic_patchpoint_codegen:
> >> >+; CHECK:       movabsq $_foo, %r11
> >> >+; CHECK-NEXT:  callq   *%r11
> > Wouldn't it be better just to emit:
> >
> >    callq	_foo
> >
> > instead of the move and then the indirect call?
> Does look that way unless this is for a large code model.  Can you
> file
> a bug?

PR24145.

Thanks again,
Hal

> >
> >   -Hal
> >
> 
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory