[Patch][LoopVectorize] Renaming and Diagnostics for Loop Interleaving

[Tyler Nowicki]

Committed in r241971.

Gerolf and Hal does the patch http://reviews.llvm.org/D10714 <http://reviews.llvm.org/D10714> meet your quality requirements? Would you prefer to see some upfront work on the ‘already vectorized’ and ‘vectorize(disable)/vectorize_width(1)’ issues?

Thanks,

Tyler

> On Jul 9, 2015, at 6:56 PM, Hal Finkel <hfinkel at anl.gov> wrote:
> 
> This 0002-Rename-some-uses-of-unroll-to-interleave.patch LGTM.
> 
> -Hal
> 
> ----- Original Message -----
>> From: "Tyler Nowicki" <tnowicki at apple.com>
>> To: "Hal J. Finkel" <hfinkel at anl.gov>
>> Cc: "Commit Messages and Patches for LLVM" <llvm-commits at cs.uiuc.edu>, "Gerolf Hoflehner" <ghoflehner at apple.com>
>> Sent: Wednesday, June 24, 2015 6:23:45 PM
>> Subject: Re: [Patch][LoopVectorize] Renaming and Diagnostics for Loop Interleaving
>> 
>> 
>> Hi Hal,
>> 
>> 
>> Sorry about the 80 column limit. I put the main patch on phabricator,
>> sorry if you received some spam related to this. I am not very
>> familiar with it.
>> 
>> 
>> http://reviews.llvm.org/D10714
>> 
>> 
>> Here is the renaming patch again with the column limit fixed.
>> 
>> 
>> Thanks,
>> 
>> 
>> Tyler
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> On Jun 22, 2015, at 5:18 PM, Hal Finkel < hfinkel at anl.gov > wrote:
>> 
>> Hi Tyler,
>> 
>> Please upload these patches to phabricator for review. I'd find that
>> much easier. Also, you have many lines in these patches that violate
>> the 80 column limit.
>> 
>> Thanks again,
>> Hal
>> 
>> ----- Original Message -----
>> 
>> 
>> From: "Tyler Nowicki" < tnowicki at apple.com >
>> To: llvm-commits at cs.uiuc.edu
>> Sent: Monday, June 22, 2015 12:52:34 PM
>> Subject: Re: [Patch][LoopVectorize] Renaming and Diagnostics for Loop
>> Interleaving
>> 
>> Hi,
>> 
>> I would appreciate a review of these patches.
>> 
>> Thanks,
>> 
>> Tyler
>> 
>> 
>> 
>> On Jun 15, 2015, at 6:30 PM, Tyler Nowicki < tnowicki at apple.com >
>> wrote:
>> 
>> Hi,
>> 
>> Here is a renaming patch for names like unroll factor to names like
>> interleave count and a patch that improves the diagnostics for
>> interleaving so the user knows when they have explicitly disabled
>> interleaving and when it is not profitable. Includes test cases.
>> 
>> Any comments are much appreciated!
>> 
>> Tyler
>> 
>> <0002-Rename-some-uses-of-unroll-to-interleave.patch><0003-Modify-diagnostic-messages-to-clearly-indicate-the-w.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> 
>> --
>> Hal Finkel
>> Assistant Computational Scientist
>> Leadership Computing Facility
>> Argonne National Laboratory
>> 
>> 
> 
> -- 
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150715/b0ae9575/attachment.html>