[PATCH] D11082: [CMake] Adding some utility functions for Darwin builds into a new CompilerRTDarwinUtils.cmake module

[Alexey Samsonov]

samsonov added inline comments.

================
Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:4
@@ +3,3 @@
+# the current Xcode.
+function(find_darwin_sdk_dir var sdk_name)
+  # Let's first try the internal SDK, otherwise use the public SDK.
----------------
Please actually use this function in `CMakeLists.txt` (and delete macro used there).

================
Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:26
@@ +25,3 @@
+# link for.
+function(darwin_get_toolchain_supported_archs output_var)
+  execute_process(
----------------
Looks like this should be the Darwin version of the complex code that generates `COMPILER_RT_SUPPORTED_ARCH`. Can you just call it from there?

================
Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:79
@@ +78,1 @@
+endfunction()
\ No newline at end of file

----------------
please fix


http://reviews.llvm.org/D11082