[PATCH] D11214: [PM/AA] Remove the addEscapingUse update API that won't be easy to directly model in the new PM.

Gerolf Hoflehner ghoflehner at apple.com
Wed Jul 15 14:21:06 PDT 2015


Gerolf added a comment.

I don't know this code well enough for a quality review. Certainly agree with the notion that this is a very brittle interface that is hard to maintain. And I trust your judgement that the original intent it was invented for is now obsolete. LGTM with these constraints. Also, as a bit orthogonal issue, but since you argue with ease of migration to the new pass manager (NPM): do you have a list of (potentially) performance relevant passes that could run into integration issues down the road? I suspect more(similar) performance-stability trade-offs on the road to NPM. Thanks!


http://reviews.llvm.org/D11214







More information about the llvm-commits mailing list