[PATCH] D11213: [PM/AA] Disable the core unsafe aspect of GlobalsModRef in the face of basic changes to the IR such as folding pointers through PHIs, Selects, integer casts, store/load pairs, or outlining.

[Gerolf Hoflehner]

Gerolf added inline comments.

================
Comment at: lib/Analysis/IPA/GlobalsModRef.cpp:51
@@ +50,3 @@
+// These unsafe results have been returned by GMR for many years without
+// causing significant issues is the wild and so we provide a mechanism to
+// re-enable them for users of LLVM that have a particular performance
----------------
is -> in

================
Comment at: lib/Analysis/IPA/GlobalsModRef.cpp:56
@@ +55,3 @@
+static cl::opt<bool> EnableUnsafeGlobalsModRefAliasResults(
+    "enable-unsafe-globalsmodref-alias-results", cl::init(false));
+
----------------
My preference for default is 'true'. Innocent until proven guilty -  with test case counting as a proof. If performance data is in the noise I will switch my preference.


http://reviews.llvm.org/D11213