[PATCH] D11225: AMDPGU/SI: Use AssertAnd node to mask high bit for scratch offsets
Matt Arsenault
Matthew.Arsenault at amd.com
Wed Jul 15 10:43:35 PDT 2015
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:824-826
@@ +823,5 @@
+ //
+ // It may be theoretically possible to construct a system that makes
+ // 128 GB of memory accessible to the GPU, but for now we assume such
+ // machines do not exist.
+ //
----------------
arsenm wrote:
> I think this should be wrapped under a subtarget feature (that defaults to on) and use a more conservative assumption if off. For a name idea -huge-memory-support or something like that
By default to on I mean this should default to happening rather than default the conservative assumption
http://reviews.llvm.org/D11225
More information about the llvm-commits
mailing list