[PATCH] D11220: Correct lowering of memmove in NVPTX

Eli Bendersky eliben at google.com
Wed Jul 15 08:11:35 PDT 2015


eliben added a comment.

In http://reviews.llvm.org/D11220#205430, @jholewinski wrote:

> The algorithm looks good.  Thanks for working on this!
>
> Though I'm wondering if this shouldn't be moved to the CodeGen library.  Other targets may be able to benefit from this, like AMDGPU.


Thanks for the quick review, Justin.

Re AMDGPU, I prefer not to generalize prematurely, because maybe YAGNI :-) AMDGPU folks may or may not need this... They are free to adopt and generalize this if they do need it and I'll be happy to help, of course.


Repository:
  rL LLVM

http://reviews.llvm.org/D11220







More information about the llvm-commits mailing list