[PATCH] D10207: Handle cast instructions in complete loop unroll heuristic.

Chandler Carruth chandlerc at gmail.com
Tue Jul 14 14:44:13 PDT 2015


chandlerc added a comment.

This patch looks fine, but I'd like to have a test case that specifically exercises it. Is that possible given the current state, or does that come in a subsequent patch?


================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:444
@@ +443,3 @@
+  bool visitCastInst(CastInst &I) {
+    // Propagate constants through ptrtoint.
+    Constant *COp = dyn_cast<Constant>(I.getOperand(0));
----------------
This comment still seems stale (referring to ptrtoint).


http://reviews.llvm.org/D10207







More information about the llvm-commits mailing list