[PATCH] D11195: [PeepholeOptimizer] Refactor optimizeUncoalescable logic. NFC
Quentin Colombet
qcolombet at apple.com
Tue Jul 14 14:29:36 PDT 2015
qcolombet added a comment.
Hi Bruno,
Nice refactoring!
LGTM with one nit.
Please commit with that updated.
Cheers,
-Quentin
================
Comment at: lib/CodeGen/PeepholeOptimizer.cpp:339
@@ -287,3 +338,3 @@
/// alternative source has been found.
- const MachineInstr *getNextSource(unsigned &SrcReg, unsigned &SrcSubReg);
+ ValueTrackerResult getNextSource();
----------------
The comment here needs further update as SrcReg and SrcSubReg are not parameters anymore.
Repository:
rL LLVM
http://reviews.llvm.org/D11195
More information about the llvm-commits
mailing list