[PATCH] D11179: [asan] Invalid debug info for promotable allocas

[Kostya Serebryany]

kcc added a comment.

Two style comments.
Also, please add a test.


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:528
@@ -527,2 +527,3 @@
   SmallVector<AllocaInst *, 16> AllocaVec;
+  SmallVector<AllocaInst *, 16> NonInstrumentedAllocaVec;
   SmallVector<Instruction *, 8> RetVec;
----------------
NonInstrumentedStaticAllocaVec

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1741
@@ -1736,1 +1740,3 @@
 
+  for (auto *AI : NonInstrumentedAllocaVec) {
+    AI->moveBefore(AllocaVec[0]);
----------------
This code tends to not have {} in such case. 


http://reviews.llvm.org/D11179