[PATCH] D10967: [mips] Fix li/la differences between IAS and GAS.

Daniel Sanders daniel.sanders at imgtec.com
Tue Jul 14 05:22:36 PDT 2015


dsanders marked 3 inline comments as done.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1882-1886
@@ -1854,6 +1881,7 @@
       SrcReg = Mips::ZERO;
     tmpInst.setOpcode(Mips::ADDiu);
     tmpInst.addOperand(MCOperand::createReg(DstReg));
     tmpInst.addOperand(MCOperand::createReg(SrcReg));
     tmpInst.addOperand(MCOperand::createImm(ImmValue));
     Instructions.push_back(tmpInst);
+  } else if (isUInt<16>(ImmValue)) {
----------------
vkalintiris wrote:
> Can you use your newly defined emitRR* functions here and for the ORi instruction down below (lines: 1912-1917)?
Done. I've also done the LUi's.


http://reviews.llvm.org/D10967







More information about the llvm-commits mailing list