[PATCH] Fix test-release.sh to use DESTDIR

Dan Liew dan at su-root.co.uk
Mon Jul 13 23:41:13 PDT 2015


Hi,

> I'll have a go at redoing the patch.

Here's a new version of the patch. It sets the install prefix (and
does not set DESTDIR) for phase 1 and 2, and for phase 3 it uses
/usr/local as install the prefix and sets DESTDIR to be a temporary
folder.

I ended up removing the ``-disable-clang`` option. It would have made
the logic for setting --prefix and DESTDIR more complicated and also
it was kind of broken because if ``-disable-clang`` was set then
``package_release`` step would fail (possibly silently if there was an
old phase 3 build lying around) because it assumed that phase 3 had
been run. I don't think there's a good reason to skip running the 3
phase build when preparing for a release so I think removing this is
okay.

Thanks,
Dan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_release_use_destdirV3.patch
Type: text/x-patch
Size: 8266 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150713/351f59fb/attachment.bin>


More information about the llvm-commits mailing list