[PATCH] D10910: RAGreedy: Keep track of allocated PhysRegs internally

Jakob Stoklund Olesen stoklund at 2pi.dk
Mon Jul 13 20:25:10 PDT 2015


stoklund accepted this revision.
stoklund added a reviewer: stoklund.
This revision is now accepted and ready to land.

================
Comment at: lib/CodeGen/RegAllocGreedy.cpp:829
@@ +828,3 @@
+  for (MCRegUnitIterator Unit(CSR, TRI); Unit.isValid(); ++Unit) {
+    if (!Matrix->getLiveUnions()[*Unit].empty())
+      return false;
----------------
This looks like the guts of LiveRegMatrix are spilling out.

How about moving this code into a LiveRegMatrix::isPhysRegUsed() function instead?

Otherwise, looks good!


Repository:
  rL LLVM

http://reviews.llvm.org/D10910







More information about the llvm-commits mailing list