[PATCH] Fix test-release.sh to use DESTDIR
Hans Wennborg
hans at chromium.org
Mon Jul 13 17:54:35 PDT 2015
Hi Dan,
Now back from vacation :-)
Thanks for the explanation of --prefix v.s. DESTDIR above.
On Sun, Jul 5, 2015 at 9:18 PM, Dan Liew <dan at su-root.co.uk> wrote:
> Apologies. There was a mistake in the original patch that caused the
> test-release.sh script to fail between building the different stages.
> Attached is the new version of the patch which seems to work correctly
> on my local machine.
The patch looks great, but I don't see any reason to make the prefix
configurable in this script. The default value of --prefix should be
good, so can't we just drop it, along with the InstallPrefix variable
and the command-line option? If that sounds OK to you, please go ahead
and commit.
Thanks,
Hans
More information about the llvm-commits
mailing list