[llvm] r241974 - [ExecutionEngine] Add a static cast to the unittest for r241962 to suppress a

[Eric Christopher]

On Mon, Jul 13, 2015 at 4:16 PM David Blaikie <dblaikie at gmail.com> wrote:

> On Fri, Jul 10, 2015 at 7:07 PM, Lang Hames <lhames at gmail.com> wrote:
>
>> Author: lhames
>> Date: Fri Jul 10 21:07:28 2015
>> New Revision: 241974
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=241974&view=rev
>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D241974-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=0WHGHjeELyWXv0PTPpHuLvqY33vJY_uDL27b5ciaZSA&s=lplG_99g4txxrfVTi_H9bZZP509eeDIacXVYuS6Nrfo&e=>
>> Log:
>> [ExecutionEngine] Add a static cast to the unittest for r241962 to
>> suppress a
>> warning.
>>
>> Modified:
>>     llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp
>>
>> Modified: llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp?rev=241974&r1=241973&r2=241974&view=diff
>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_unittests_ExecutionEngine_MCJIT_MCJITTest.cpp-3Frev-3D241974-26r1-3D241973-26r2-3D241974-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=0WHGHjeELyWXv0PTPpHuLvqY33vJY_uDL27b5ciaZSA&s=sdrmEL4koHZ-c4g_ZG86uvUFXqB83kHSmMoP6x2jdTY&e=>
>>
>> ==============================================================================
>> --- llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp (original)
>> +++ llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITTest.cpp Fri Jul 10
>> 21:07:28 2015
>> @@ -258,7 +258,7 @@ TEST_F(MCJITTest, lazy_function_creator_
>>
>>    // Verify that our handler was called for each unresolved function.
>>    auto I = UnresolvedExternals.begin(), E = UnresolvedExternals.end();
>> -  EXPECT_EQ(UnresolvedExternals.size(), 2);
>> +  EXPECT_EQ(UnresolvedExternals.size(), static_cast<size_t>(2));
>>
>
> Could use "2u" instead, if you like. (I think that's how I usually fix
> this issue - not sure what's dominant across the LLVM unit tests)
>

AFAICT "2u" would be the 'canonical' way to fix it yes.

-eric


>
>
>>    EXPECT_FALSE(std::find(I, E, "Foo1") == E);
>>    EXPECT_FALSE(std::find(I, E, "Foo2") == E);
>>  }
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150713/a16b91b4/attachment.html>