[PATCH] D11140: [ELF/AArch64] Fix export TLS dynamic symbol

[Rui Ueyama]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with nits about styles.


================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.cpp:40
@@ +39,3 @@
+          if (section->hasGlobalGOTEntry(atom->_atom))
+            this->_dynamicSymbolTable->addSymbol(atom->_atom,
+                                                 section->ordinal(),
----------------
If you can remove "this->", please do.

================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64SectionChunks.cpp:19
@@ -20,1 +18,3 @@
+  : AtomSection<ELF64LE>(ctx, name, DefinedAtom::typeGOT, DefinedAtom::permRW_,
+    order) {
   this->_alignment = 8;
----------------
Ditto

================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64SectionChunks.h:21
@@ -21,1 +20,3 @@
+  AArch64GOTSection(const ELFLinkingContext &ctx, StringRef name,
+    int32_t order);
 
----------------
I think the indentation does not follow the LLVM style.

================
Comment at: lib/ReaderWriter/ELF/AArch64/AArch64TargetHandler.cpp:28
@@ +27,3 @@
+    auto section = new (this->_allocator) AArch64GOTSection(this->_ctx, name,
+      order);
+    _gotSections.push_back(section);
----------------
Ditto


http://reviews.llvm.org/D11140