[PATCH] D11146: [ValueTracking] Add support for floating-point minnum and maxnum

[James Molloy]

jmolloy added inline comments.

================
Comment at: lib/Transforms/InstCombine/InstCombineSelect.cpp:42
@@ -42,1 +41,3 @@
+static CmpInst::Predicate getCmpPredicateForMinMax(SelectPatternFlavor SPF,
+                                                   bool Ordered=false) {
   switch (SPF) {
----------------
I've currently put the onus on the user of matchSelectPattern to work out if an ordered or unordered FCMP is needed. I was in two minds about this, the alternative being to change matchSelectPattern to return a struct containing the pattern kind, the orderedness and the fast-math flags if applicable.


Repository:
  rL LLVM

http://reviews.llvm.org/D11146