[PATCH] D11143: [RFC] Cross Block DSE

Evgeny Astigeevich evgeny.astigeevich at arm.com
Mon Jul 13 07:57:37 PDT 2015


eastig added inline comments.

================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:655
@@ -620,3 +654,3 @@
   // dead at its end, which means stores to them are also dead.
-  if (BB.getTerminator()->getNumSuccessors() == 0)
-    MadeChange |= handleEndBlock(BB);
+  if (TerminatorInst *TI = BB.getTerminator())
+    if (TI->getNumSuccessors() == 0)
----------------
'nullptr' is returned when BB is not well formed. Maybe it's better to 'assert' here?


http://reviews.llvm.org/D11143







More information about the llvm-commits mailing list