[PATCH] D11110: Make ExecutionEngine owning a DataLayout

Mehdi AMINI mehdi.amini at apple.com
Sat Jul 11 20:23:48 PDT 2015


joker.eph added inline comments.

================
Comment at: lib/ExecutionEngine/MCJIT/MCJIT.cpp:71
@@ -70,4 +70,3 @@
              std::shared_ptr<RuntimeDyld::SymbolResolver> Resolver)
-    : ExecutionEngine(std::move(M)), TM(std::move(tm)), Ctx(nullptr),
-      MemMgr(std::move(MemMgr)), Resolver(*this, std::move(Resolver)),
-      Dyld(*this->MemMgr, this->Resolver), ObjCache(nullptr) {
+    : ExecutionEngine(*TM->getDataLayout(), std::move(M)), TM(std::move(TM)),
+      Ctx(nullptr), MemMgr(std::move(MemMgr)),
----------------
echristo wrote:
> Grab the DataLayout off the Module here?
Since the Module DL can be the default one and it will be overridden with the one of the TargetMachine later and before processing, we really don't want to get the one from the Module here.


http://reviews.llvm.org/D11110







More information about the llvm-commits mailing list