[PATCH] D10679: Internalize: internalize comdat members as a group, and drop comdat on such members.
Peter Collingbourne
peter at pcc.me.uk
Sat Jul 11 13:54:54 PDT 2015
pcc added inline comments.
================
Comment at: lib/Transforms/IPO/Internalize.cpp:256
@@ -216,3 +255,3 @@
- return Changed;
+ return true;
}
----------------
rafael wrote:
> Any reason to drop the tracking of Changed? I don't think it makes a difference given how this pass is used, but we should at least comment on why it is not done.
Added a comment with an explanation.
http://reviews.llvm.org/D10679
More information about the llvm-commits
mailing list