[PATCH] D11107: DAGCombiner: Don't search up chain through non-memory dependencies

hfinkel at anl.gov hfinkel at anl.gov
Fri Jul 10 14:15:13 PDT 2015


hfinkel added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14022
@@ +14021,3 @@
+          // e.g. we could have a dependency on a CopyFromReg into the pointer
+          // value of a load.
+          Chains.push_back(Chain);
----------------
Can you explain exactly what situation your trying to prevent and why it is bad? I don't understand the problem from the referenced mailing-list message because everything there looks legal.



http://reviews.llvm.org/D11107







More information about the llvm-commits mailing list