[PATCH] D11076: [ELF/AArch64] Fix export TLS dynamic symbol

[Adhemerval Zanella]

On 09-07-2015 19:06, Rui Ueyama wrote:
> ruiu added inline comments.
> 
> ================
> Comment at: lib/ReaderWriter/ELF/AArch64/AArch64SectionChunks.h:35-47
> @@ -32,2 +34,15 @@
>  
> +class AArch64GOTSection : public AArch64GOTBaseSection {
> +public:
> +  AArch64GOTSection(const ELFLinkingContext &ctx)
> +    : AArch64GOTBaseSection(ctx, ".got", TargetLayout<ELF64LE>::ORDER_GOT) {}
> +};
> +
> +class AArch64GOTPLTSection : public AArch64GOTBaseSection {
> +public:
> +  AArch64GOTPLTSection(const ELFLinkingContext &ctx)
> +    : AArch64GOTBaseSection(ctx, ".got",
> +                            TargetLayout<ELF64LE>::ORDER_GOT_PLT) {}
> +};
> +
>  } // elf
> ----------------
> I don't think these classes are needed. You can just pass "order" argument when you create an instance of AArch64GOTBaseSection.

I created them to help instantiation and I see my initial patch contains an
issue: AArch64GOTPLTSection name section should be '.got.plt' instead.  I will
remove the classes and fix it, thanks.