[PATCH] D10398: Add read_write_arg_mem attribute

hfinkel at anl.gov hfinkel at anl.gov
Fri Jul 10 04:15:52 PDT 2015


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

With the change below, LGTM.


================
Comment at: docs/LangRef.rst:1331
@@ +1330,3 @@
+    This attribute indicates that the only memory accesses inside function are
+    non-volatile, non-atomic loads and stores from objects pointed to by its
+    pointer-typed arguments, with arbitrary offsets. Or in other words, all
----------------
Actually, I think these are orthogonal concepts. Can you remove mentioning both volatile and atomic? How it accesses memory, and whether that access might have side effects, can be specified separately (via readonly, or the lack thereof, etc.) from which memory might be accessed.



Repository:
  rL LLVM

http://reviews.llvm.org/D10398







More information about the llvm-commits mailing list