[PATCH] D11058: Parser support for string attributes on arguments/return values

[hfinkel at anl.gov]

hfinkel added a comment.

In http://reviews.llvm.org/D11058#202655, @apilipenko wrote:

> In http://reviews.llvm.org/D11058#202557, @hfinkel wrote:
>
> > Which API?
>
>
> Function *function;
>  function->setAttributes(function->getAttributes().addAttribute(context, i, "attribute"));


I think the intent was for string attributes only to appear in attribute groups (http://llvm.org/docs/LangRef.html#attribute-groups), not as parameter attributes. I don't object to extending this, but we need to have a conversation on llvmdev first about the extension.


http://reviews.llvm.org/D11058