[PATCH] D10667: [llvm-stress] Enhance scalar type selection from command line.

Paweł Bylica chfast at gmail.com
Fri Jul 10 01:27:34 PDT 2015


chfast added inline comments.

================
Comment at: tools/llvm-stress/llvm-stress.cpp:702
@@ -686,3 +701,3 @@
   // Init LLVM, call llvm_shutdown() on exit, parse args, etc.
-  llvm::PrettyStackTraceProgram X(argc, argv);
+  PrettyStackTraceProgram X(argc, argv);
   cl::ParseCommandLineOptions(argc, argv, "llvm codegen stress-tester\n");
----------------
hfinkel wrote:
> Not clear why you're removing the llvm:: here in favor of adding 'using namespace llvm;'. I don't have a problem with it, but if it is an independent change, please split it into a separate commit.
> 
> 
It's not like that. I moved the `using namespace llvm` from the top of the file because I had to specialize the template inside the llvm namespace up there.

Removing the llvm prefix was only for consistency as all other functions inside the main() skip the prefix. I will send that part in a separate commit.


http://reviews.llvm.org/D10667







More information about the llvm-commits mailing list